feat(extensions): align static skills and Codex MCP import - #1899
Merged
limityan merged 1 commit intoJul 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This combines two independently bounded extension improvements in one delivery PR:
Design boundaries
allowed-toolsnever grants capabilities.Adversarial review
A fresh-context subagent reviewed the complete diff. No P0/P1 issue remained. The review led to fixes for Codex implicit-cwd handling, selection changes during an active import, runtime-sensitive Skill frontmatter rejection, and stale CLI documentation.
One deliberate low-risk boundary remains: source/scope labels are resolved from the current catalog snapshot. A candidate that appears only after planning can briefly show
Unknown; expanding the public plan DTO solely for this presentation edge was rejected as out of scope. The stale candidate still cannot be imported accidentally.Verification
cargo check --workspacecargo test -p bitfun-agent-runtime --test skill_contracts(29 passed)cargo test -p bitfun-services-core --features markdown --test markdown_owner_contracts(9 passed)cargo test -p bitfun-product-domains --features external-sources --test external_source_contracts(42 passed)cargo test -p bitfun-codex-adapter --test mcp_source(16 passed)cargo test -p bitfun-core claude --lib -- --nocapture(5 passed)cargo test -p bitfun-cli mcp_import::tests::render_plan -- --nocapture(2 passed)pnpm run type-check:webpnpm run lint:webnode scripts/check-core-boundaries.mjspnpm run check:repo-hygienepnpm run i18n:auditpnpm run theme:color-audit:all